HyukjinKwon commented on code in PR #40066:
URL: https://github.com/apache/spark/pull/40066#discussion_r1111999039
##########
python/pyspark/sql/connect/client.py:
##########
@@ -632,7 +632,7 @@ def _execute(self, req: pb2.ExecutePlanRequest) -> None:
Proto representation of the plan.
"""
- logger.info("Execute")
+ logger.debug(f"Execute request: » {os.linesep}{req}{os.linesep} «")
Review Comment:
Maybe just `Execute request: {os.linesep}{req}{os.linesep}`? I would stick
to the existing codebase unless it needs a reason.
It's also sort of documented:
> If you’re not sure about the right style for something, try to follow the
style of the existing codebase
https://spark.apache.org/contributing.html
So I wouldn't do something new unless there's a reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
