LucaCanali commented on PR #39127: URL: https://github.com/apache/spark/pull/39127#issuecomment-1437434751
Thank you @tgravescs and @attilapiros for reviewing this. As for adding a test for this change, my first comm is that I see that existing tests already cover YARN_EXCLUDE_NODES functionality. We could think of a specific test that covers the behavior when dynamic allocation is turned on and off, however in the current test infrastructure that I see with for YarnAllocatorHealthTrackerSuite or YarnAllocatorSuite, it does not look (to me) like as easy task. Would you have any further clues? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
