gengliangwang commented on code in PR #40080:
URL: https://github.com/apache/spark/pull/40080#discussion_r1113508808
##########
connector/protobuf/src/test/scala/org/apache/spark/sql/protobuf/ProtobufSerdeSuite.scala:
##########
@@ -144,44 +146,52 @@ class ProtobufSerdeSuite extends SharedSparkSession with
ProtobufTestBase {
test("Fail to convert with missing Catalyst fields") {
val protoFile = ProtobufUtils.buildDescriptor(testFileDesc,
"FieldMissingInSQLRoot")
- // serializing with extra fails if extra field is missing in SQL Schema
+ val foobarSQLType = DataType.fromDDL(
+ "struct<foo string>" // "bar" is missing.
Review Comment:
Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
