grundprinzip commented on code in PR #39995:
URL: https://github.com/apache/spark/pull/39995#discussion_r1114946105
##########
connector/connect/common/src/main/protobuf/spark/connect/base.proto:
##########
@@ -183,6 +183,85 @@ message ExecutePlanResponse {
}
}
+// Request to update or fetch the configurations.
+message ConfigRequest {
+ // (Required)
+ //
+ // The client_id is set by the client to be able to collate streaming
responses from
+ // different queries.
+ string client_id = 1;
+
+ // (Required) User context
+ UserContext user_context = 2;
+
+ Operation operation = 3;
+
+ // (Optional)
+ //
+ // Identify which keys will be updated or fetched.
+ // Required when the 'operation' is 'SET', 'GET', 'GET_OPTION', 'UNSET',
+ // 'CONTAINS', 'IS_MODIFIABLE'.
+ repeated string keys = 4;
+
+ // (Optional)
+ //
+ // Corresponding values to the keys.
+ // Required when the 'operation' is 'SET'.
+ // Optional when the 'operation' is 'GET', the values here will be used
+ // as the default values.
+ repeated string values = 5;
Review Comment:
I find the reuse in case of GET/SET hard to reason about
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
