hvanhovell commented on code in PR #40129:
URL: https://github.com/apache/spark/pull/40129#discussion_r1115163152
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/RelationalGroupedDataset.scala:
##########
@@ -225,3 +234,28 @@ class RelationalGroupedDataset protected[sql] (
toDF(colNames.map(colName => functions.sum(colName)))
}
}
+
+private[sql] object RelationalGroupedDataset {
Review Comment:
For the record, I would also be fine with you using the proto enums. From
the look of it there is no real way a user can interact with this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
