huaxingao commented on code in PR #40134:
URL: https://github.com/apache/spark/pull/40134#discussion_r1115304895
##########
connector/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/DB2IntegrationSuite.scala:
##########
@@ -217,4 +217,25 @@ class DB2IntegrationSuite extends
DockerJDBCIntegrationSuite {
assert(actual.length === 2)
assert(actual.toSet === expectedResult)
}
+
+ test("SPARK-42534: DB2 Limit pushdown test") {
+ val actual = sqlContext.read
+ .format("jdbc")
+ .option("url", jdbcUrl)
+ .option("dbtable", "tbl")
+ .load()
+ .limit(2)
Review Comment:
Limit push down is only supported in V2 JDBC. I don't think this `limit(2)`
will trigger the newly added `DB2Dialect.getLimitClause`. This test should be
done in `v2/DB2IntegrationSuite`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
