amaliujia commented on code in PR #40135:
URL: https://github.com/apache/spark/pull/40135#discussion_r1115332180


##########
python/pyspark/sql/tests/test_dataframe.py:
##########
@@ -144,6 +144,17 @@ def test_drop_duplicates(self):
             message_parameters={"arg_name": "subset", "arg_type": "str"},
         )
 
+    def test_drop_duplicates_with_multi_args(self):

Review Comment:
   Nit: I feel that this test name is not clear to tell this is to test 
`AMBIGUOUS_REFERENCE`.
   
   I guess either rename it to something like 
`test_drop_duplicates_with_ambiguous_reference` or add a comment like `# 
SPARK-XXXX: test drop API when there are ambiguous reference`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to