zhenlineo commented on code in PR #40136:
URL: https://github.com/apache/spark/pull/40136#discussion_r1116156560
##########
connector/connect/client/jvm/pom.xml:
##########
@@ -125,6 +125,11 @@
<version>${mima.version}</version>
<scope>test</scope>
</dependency>
+ <dependency>
Review Comment:
I kind of understand the `SimpleSparkConnectService` started the test with
the client classpath, but then the submit script should scan all spark
dependencies independently. See this code in spark-class:
https://github.com/apache/spark/blob/master/bin/spark-class#L38-L43
These are the real jars that are pulled into the spark when starting. So I
feel we should ensure the jars are put into these jar folders correctly instead
of modifying the client.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
