cloud-fan commented on code in PR #39954:
URL: https://github.com/apache/spark/pull/39954#discussion_r1116461015
##########
sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala:
##########
@@ -557,6 +557,20 @@ abstract class JdbcDialect extends Serializable with
Logging {
def getJdbcSQLQueryBuilder(options: JDBCOptions): JdbcSQLQueryBuilder =
new JdbcSQLQueryBuilder(this, options)
+ /**
+ * Returns ture if dialect supports LIMIT clause.
+ *
+ * Note: Some build-in dialect supports LIMIT clause with some trick, please
see:
+ * {@link OracleDialect.OracleSQLQueryBuilder} and
+ * {@link MsSqlServerDialect.MsSqlServerSQLQueryBuilder}.
+ */
+ def supportsLimit: Boolean = true
+
+ /**
+ * Returns ture if dialect supports OFFSET clause.
+ */
+ def supportsOffset: Boolean = true
Review Comment:
I think it's better to use false as the default value, and override it in
builtin dialects in return true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
