allisonport-db commented on code in PR #38823:
URL: https://github.com/apache/spark/pull/38823#discussion_r1116469149
##########
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala:
##########
@@ -1422,6 +1422,162 @@ class DataSourceV2SQLSuiteV1Filter
}
}
+ test("SPARK-41290: Generated columns only allowed with TableCatalogs that " +
+ "SUPPORTS_CREATE_TABLE_WITH_GENERATED_COLUMNS") {
+ val tblName = "my_tab"
+ val tableDefinition =
+ s"$tblName(eventDate DATE, eventYear INT GENERATED ALWAYS AS
(year(eventDate)))"
+ for (statement <- Seq("CREATE TABLE", "REPLACE TABLE")) {
+ // InMemoryTableCatalog.capabilities() =
{SUPPORTS_CREATE_TABLE_WITH_GENERATED_COLUMNS}
+ withTable(s"testcat.$tblName") {
+ if (statement == "REPLACE TABLE") {
+ sql(s"CREATE TABLE testcat.$tblName(a INT) USING foo")
+ }
+ // Can create table with a generated column
+ sql(s"$statement testcat.$tableDefinition USING foo")
+
assert(catalog("testcat").asTableCatalog.tableExists(Identifier.of(Array(),
tblName)))
+ }
+ // BasicInMemoryTableCatalog.capabilities() = {}
+ withSQLConf("spark.sql.catalog.dummy" ->
classOf[BasicInMemoryTableCatalog].getName) {
+ checkError(
+ exception = intercept[AnalysisException] {
+ sql("USE dummy")
+ sql(s"$statement dummy.$tableDefinition USING foo")
+ },
+ errorClass = "UNSUPPORTED_FEATURE.TABLE_OPERATION",
+ parameters = Map(
+ "tableName" -> "`my_tab`",
+ "operation" -> "generated columns"
+ )
+ )
+// val e = intercept[AnalysisException] {
Review Comment:
accidentally included, it's identical to the `checkError` above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
