amaliujia commented on code in PR #40150:
URL: https://github.com/apache/spark/pull/40150#discussion_r1117500909
##########
connector/connect/common/src/main/protobuf/spark/connect/base.proto:
##########
@@ -183,6 +183,141 @@ message ExecutePlanResponse {
}
}
+// The placeholder for the config request and response when the values can be
optional.
+message OptionalValue {
+ optional string value = 1;
+}
+
+// The key-value pair for the config request and response.
+message KeyValue {
+ string key = 1;
+ string value = 2;
+}
+
+// The key-value pair for the config request and response when the value can
be optional.
+message OptionalKeyValue {
+ string key = 1;
+ OptionalValue value = 2;
+}
Review Comment:
Nit that please follow the proto style guide to mark each of the field by
`(Required)` or `(Optional)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
