hvanhovell commented on code in PR #40160:
URL: https://github.com/apache/spark/pull/40160#discussion_r1118918930
##########
connector/connect/common/src/main/protobuf/spark/connect/base.proto:
##########
@@ -152,12 +152,23 @@ message ExecutePlanRequest {
message ExecutePlanResponse {
string client_id = 1;
- ArrowBatch arrow_batch = 2;
+ oneof response_type {
+ ArrowBatch arrow_batch = 2;
+
+ SqlCommandResult sql_command_result = 5;
+
+ // Support arbitrary result objects.
+ google.protobuf.Any extension = 999;
+ }
// Metrics for the query execution. Typically, this field is only present in
the last
// batch of results and then represent the overall state of the query
execution.
Metrics metrics = 4;
+ message SqlCommandResult {
Review Comment:
How about we return an actual relation here? In that case the client can
just plug this into their dataframe.
- Command would be a `LocalRelation` with any result contained inside of it.
- Other would be SQL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
