sunchao commented on code in PR #40144:
URL: https://github.com/apache/spark/pull/40144#discussion_r1119075418
##########
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveUtilsSuite.scala:
##########
@@ -77,6 +80,32 @@ class HiveUtilsSuite extends QueryTest with SQLTestUtils
with TestHiveSingleton
}
}
+ test("SPARK-42539 User-provided JARs should not take precedence over builtin
Hive JARs") {
Review Comment:
nit: add a colon after `SPARK-42539`
##########
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveUtilsSuite.scala:
##########
@@ -19,13 +19,16 @@ package org.apache.spark.sql.hive
import org.apache.hadoop.conf.Configuration
import org.apache.hadoop.hive.conf.HiveConf.ConfVars
-
-import org.apache.spark.SparkConf
+import org.apache.spark.{SparkConf, TestUtils}
import org.apache.spark.deploy.SparkHadoopUtil
import org.apache.spark.sql.QueryTest
+import org.apache.spark.sql.catalyst.catalog.CatalogDatabase
import org.apache.spark.sql.hive.test.TestHiveSingleton
import org.apache.spark.sql.test.SQLTestUtils
-import org.apache.spark.util.ChildFirstURLClassLoader
+import org.apache.spark.util.{ChildFirstURLClassLoader, MutableURLClassLoader}
+
+import java.io.File
Review Comment:
nit: I think we usually put `java.` imports at the beginning
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
