jerrypeng commented on code in PR #39931: URL: https://github.com/apache/spark/pull/39931#discussion_r1119310533
########## sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/WatermarkPropagator.scala: ########## @@ -0,0 +1,299 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.execution.streaming + +import java.{util => jutil} + +import scala.collection.mutable + +import org.apache.spark.internal.Logging +import org.apache.spark.sql.AnalysisException +import org.apache.spark.sql.execution.SparkPlan +import org.apache.spark.sql.internal.SQLConf +import org.apache.spark.util.Utils + +/** + * Interface for propagating watermark. The implementation is not required to be thread-safe, + * as all methods are expected to be called from the query execution thread. + * (The guarantee may change on further improvements on Structured Streaming - update + * implementations if we change the guarantee.) + */ +sealed trait WatermarkPropagator { Review Comment: So what is the relationship between this and the WatermarkTracker? The WatermarkTracker is still responsible to determining the global watermark? There is also a map in WatermarkTracker i.e. "operatorToWatermarkMap" that is used to track the watermark on a per operator basis and is used to determine the global watermark. Wouldn't the calculation for global watermark change if we are changing how watermarks for operators are calculated? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
