HyukjinKwon commented on code in PR #40203:
URL: https://github.com/apache/spark/pull/40203#discussion_r1119487978
##########
python/pyspark/sql/tests/test_functions.py:
##########
@@ -578,9 +588,13 @@ def test_approxQuantile(self):
self.assertRaises(TypeError, lambda: df.stat.approxQuantile(["a",
123], [0.1, 0.9], 0.1))
def test_sorting_functions_with_column(self):
- from pyspark.sql import functions
from pyspark.sql.column import Column
+ self.check_sorting_functions_with_column(Column)
+
+ def check_sorting_functions_with_column(self, tpe):
+ from pyspark.sql import functions
Review Comment:
no biggie but I believe we can just import this on the top
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
