wangyum commented on code in PR #40093:
URL: https://github.com/apache/spark/pull/40093#discussion_r1119798422
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala:
##########
@@ -200,14 +200,20 @@ object ConstantPropagation extends Rule[LogicalPlan] {
private def replaceConstants(condition: Expression, equalityPredicates:
EqualityPredicates)
: Expression = {
- val constantsMap = AttributeMap(equalityPredicates.map(_._1))
- val predicates = equalityPredicates.map(_._2).toSet
- def replaceConstants0(expression: Expression) = expression transform {
+ val allConstantsMap = AttributeMap(equalityPredicates.map(_._1))
+ val allPredicates = equalityPredicates.map(_._2).toSet
+ def replaceConstants0(
+ expression: Expression, constantsMap: AttributeMap[Literal]) =
expression transform {
case a: AttributeReference => constantsMap.getOrElse(a, a)
}
condition transform {
- case e @ EqualTo(_, _) if !predicates.contains(e) => replaceConstants0(e)
- case e @ EqualNullSafe(_, _) if !predicates.contains(e) =>
replaceConstants0(e)
+ case b: BinaryComparison =>
Review Comment:
The initial commit did not support it. It seems other binary comparisons
were not considered at the time:
https://github.com/apache/spark/pull/17993
Later we tried to enhance it. It seems it is not easy because there are too
many changes:
https://github.com/apache/spark/pull/24553
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
