jelmerk opened a new pull request, #40219:
URL: https://github.com/apache/spark/pull/40219

   ### What changes were proposed in this pull request?
   
   Disable substitution in values for the `StringSubstitutor` used to resolve 
error messages
   
   An alternative (better)
   
   ### Why are the changes needed?
   
   when constructing an error message `ErrorClasssesJSONReader`
   
   1. reads the error message from 
core/src/main/resources/error/error-classes.json 
   2. replaces `<fieldValue>` with `${fieldValue}` in the error message it read
   3. uses `StringSubstitutor` to replace `${fieldValue}` with the actual value
   
   If `fieldValue` is defined as "${foo}" then it will also try and resolve 
foo. 
   When foo is undefined it will throw an IllegalArgumentException
   
   This is very problematic instance in this scenario. Where parsing json will 
fail if it does not adhere to the correct schema
   
   
![image](https://user-images.githubusercontent.com/133639/221866500-99f187a0-8db3-42a7-85ca-b027fdec160d.png)
   
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   ### How was this patch tested?
   Locally
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to