hvanhovell commented on code in PR #40160:
URL: https://github.com/apache/spark/pull/40160#discussion_r1120279661
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/arrow/ArrowConverters.scala:
##########
@@ -158,7 +158,11 @@ private[sql] object ArrowConverters extends Logging {
rowCountInLastBatch < maxRecordsPerBatch)) {
val row = rowIter.next()
arrowWriter.write(row)
- estimatedBatchSize += row.asInstanceOf[UnsafeRow].getSizeInBytes
+ estimatedBatchSize += (row match {
Review Comment:
This is fine for now. For the record there are far better ways for
determining the output size. Basically you can keep track of the schema size
and the actual size of the vector root.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
