zhengruifeng commented on code in PR #40116:
URL: https://github.com/apache/spark/pull/40116#discussion_r1121008172
##########
sql/core/src/main/scala/org/apache/spark/sql/RelationalGroupedDataset.scala:
##########
@@ -89,9 +89,18 @@ class RelationalGroupedDataset protected[sql](
case expr: NamedExpression => expr
case a: AggregateExpression if
a.aggregateFunction.isInstanceOf[TypedAggregateExpression] =>
UnresolvedAlias(a, Some(Column.generateAlias))
+ case ag: UnresolvedFunction if (containsStar(Seq(ag))) || ag.isDistinct =>
+ UnresolvedAlias(expr, None)
case expr: Expression => Alias(expr, toPrettySQL(expr))()
}
+ /**
+ * Returns true if `exprs` contains a star.
+ */
+ def containsStar(exprs: Seq[Expression]): Boolean =
Review Comment:
it should be private.
since it is only used once, i think we can inline it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
