aimtsou commented on PR #40220: URL: https://github.com/apache/spark/pull/40220#issuecomment-1450611648
> OK. After this change, would this still work with numpy 1.20.0, for example? I think that's the question. Actually to make it even more clear, The only changes that are functional are related with the conversion.py file. The rest of the changes are inside tests in the user_guide or in some docstrings describing specific functions. Since I am not an expert in this tests I wait for the reviewer and some people with more experience in the pyspark code. But for your question, these types are aliases for classic python types so yes they should work with all the numpy versions [1](https://numpy.org/devdocs/release/1.20.0-notes.html), [2](https://stackoverflow.com/questions/74844262/how-can-i-solve-error-module-numpy-has-no-attribute-float-in-python) I attached 2 links which explain the use-case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
