HyukjinKwon opened a new pull request, #40245:
URL: https://github.com/apache/spark/pull/40245

   ### What changes were proposed in this pull request?
   
   This PR proposes to disable ANSI mode in `ProtoToParsedPlanTestSuite`.
   
   ### Why are the changes needed?
   
   The plan suite is independent from ANSI mode as it does not check the result 
itself, and some tests fail when ANSI mode is on:
   
   ```
   [info] - function_to_date_with_format *** FAILED *** (12 milliseconds)
   [info]   Expected and actual plans do not match:
   [info]   
   [info]   === Expected Plan ===
   [info]   Project [cast(gettimestamp(s#0, yyyy-MM-dd, TimestampType, 
Some(America/Los_Angeles), false) as date) AS to_date(s, yyyy-MM-dd)#0]
   [info]   +- LocalRelation <empty>, [d#0, t#0, s#0, x#0L, wt#0]
   [info]   
   [info]   
   [info]   === Actual Plan ===
   [info]   Project [cast(gettimestamp(s#0, yyyy-MM-dd, TimestampType, 
Some(America/Los_Angeles), true) as date) AS to_date(s, yyyy-MM-dd)#0]
   [info]   +- LocalRelation <empty>, [d#0, t#0, s#0, x#0L, wt#0] 
(ProtoToParsedPlanTestSuite.scala:129)
   [info]   org.scalatest.exceptions.TestFailedException:
   [info]   at 
org.scalatest.Assertions.newAssertionFailedException(Assertions.scala:472)
   [info]   at 
org.scalatest.Assertions.newAssertionFailedException$(Assertions.scala:471)
   [info]   at 
org.scalatest.funsuite.AnyFunSuite.newAssertionFailedException(AnyFunSuite.scala:1564)
   [info]   at org.scalatest.Assertions.fail(Assertions.scala:933)
   [info]   at org.scalatest.Assertions.fail$(Assertions.scala:929)
   [info]   at org.scalatest.funsuite.AnyFunSuite.fail(AnyFunSuite.scala:1564)
   [info]   at 
org.apache.spark.sql.connect.ProtoToParsedPlanTestSuite.$anonfun$createTest$2(ProtoToParsedPlanTestSuite.scala:129)
   [info]   at org.scalatest.OutcomeOf.outcomeOf(OutcomeOf.scala:85)
   [info]   at org.scalatest.OutcomeOf.outcomeOf$(OutcomeOf.scala:83)
   [info]   at org.scalatest.OutcomeOf$.outcomeOf(OutcomeOf.scala:104)
   ```
   
   
   ### Does this PR introduce _any_ user-facing change?
   
   No, test-only.
   
   ### How was this patch tested?
   
   Manually tested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to