zhenlineo commented on code in PR #40213:
URL: https://github.com/apache/spark/pull/40213#discussion_r1123563539
##########
connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/connect/client/CheckConnectJvmClientCompatibility.scala:
##########
@@ -184,30 +218,36 @@ class CompatibilitySuite extends ConnectFunSuite {
.filter { p =>
excludeRules.forall(rule => rule(p))
}
-
- if (problems.nonEmpty) {
- fail(
- s"\nComparing client jar: $clientJar\nand sql jar: $sqlJar\n" +
- problems.map(p => p.description("client")).mkString("\n"))
- }
+ problems
}
- test("compatibility API tests: Dataset") {
- val clientClassLoader: URLClassLoader = new
URLClassLoader(Seq(clientJar.toURI.toURL).toArray)
- val sqlClassLoader: URLClassLoader = new
URLClassLoader(Seq(sqlJar.toURI.toURL).toArray)
+ private def checkDatasetApiCompatibility(clientJar: File, sqlJar: File):
Seq[String] = {
Review Comment:
This test was initially added because we did not cover the Dataset in the
mima check.
If we found such test is useful and want to expand to more classes we can
run the mima check the other way around to ensure that our new code does not
introduce more unwanted methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
