hvanhovell commented on code in PR #40218:
URL: https://github.com/apache/spark/pull/40218#discussion_r1125240275


##########
connector/connect/common/src/main/protobuf/spark/connect/expressions.proto:
##########
@@ -189,6 +190,11 @@ message Expression {
       int32 days = 2;
       int64 microseconds = 3;
     }
+
+    message Array {
+      DataType elementType = 1;

Review Comment:
   Why do we need the element type? The element should be descriptive enough to 
figure this out.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to