Github user jdesmet commented on a diff in the pull request:
https://github.com/apache/spark/pull/6283#discussion_r30748354
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JDBCRDD.scala
---
@@ -203,7 +203,8 @@ private[sql] object JDBCRDD extends Logging {
fqTable: String,
requiredColumns: Array[String],
filters: Array[Filter],
- parts: Array[Partition]): RDD[Row] = {
+ parts: Array[Partition],
+ fetchSize: Int): RDD[Row] = {
--- End diff --
ouch - is this an additional parameter to the existing constructor? What if
there are other "hints" that can be provided to the SQL api, are we going to
continuously add additional parameters? Better to opt for a Map of parameters,
or at least going for a builder pattern. Other parameters that could be
considered is the direction of the cursor (ResultSet.TYPE_FORWARD_ONLY),
concurrency (ResultSet.CONCUR_READ_ONLY), result set direction
(ResultSet.FETCH_FORWARD), etc.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
