hvanhovell commented on code in PR #40277:
URL: https://github.com/apache/spark/pull/40277#discussion_r1126368202
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala:
##########
@@ -684,26 +686,43 @@ class SparkConnectPlanner(val session: SparkSession) {
case proto.Read.ReadTypeCase.DATA_SOURCE =>
val localMap =
CaseInsensitiveMap[String](rel.getDataSource.getOptionsMap.asScala.toMap)
val reader = session.read
- if (rel.getDataSource.hasFormat) {
- reader.format(rel.getDataSource.getFormat)
- }
localMap.foreach { case (key, value) => reader.option(key, value) }
- if (rel.getDataSource.hasSchema &&
rel.getDataSource.getSchema.nonEmpty) {
-
- DataType.parseTypeWithFallback(
- rel.getDataSource.getSchema,
- StructType.fromDDL,
- fallbackParser = DataType.fromJson) match {
- case s: StructType => reader.schema(s)
- case other => throw InvalidPlanInput(s"Invalid schema $other")
+
+ if (rel.getDataSource.getPredicatesCount == 0) {
Review Comment:
Please make the logic a bit like this:
```scala
if (format == "jdbc" && rel.getDataSource.getPredicatesCount) {
// Plan JDBC with predicates
} else id (rel.getDataSource.getPredicatesCount == 0) {
// Plan datasource
} else {
throw InvalidPlan(s"Predicates are not supported for $format datasources.)"
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
