alkis opened a new pull request, #40301:
URL: https://github.com/apache/spark/pull/40301
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR:
https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a
faster review.
7. If you want to add a new configuration, please read the guideline first
for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the
guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
Optimize `Utils.byteToString`. Arithmetic ops on `BigInt` and `BigDecimal`
are order(s) of magnitude slower than the ops on primitive types. Division is
an especially slow operation and it is used en masse here.
To avoid heating up the Earth while formatting byte counts for human
consumption we observe that most formatting operations are not in the 10s of
EiBs but on counts that fit in 64-bits and use (fastpath) 64-bit operations to
format them.
### Why are the changes needed?
Use of `Utils.byteToString` is prevalent through the codebase and they are
mainly used in logs. If the logs are emitted then this becomes a heavyweight
operation.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Existing tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
