WeichenXu123 commented on code in PR #40297: URL: https://github.com/apache/spark/pull/40297#discussion_r1127834377
########## connector/connect/server/src/main/scala/org/apache/spark/sql/connect/ml/MLUtils.scala: ########## @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.connect.ml + +import scala.reflect.ClassTag + +import org.apache.spark.connect.proto +import org.apache.spark.ml.param.{ParamMap, Params} +import org.apache.spark.sql.{DataFrame, Dataset} +import org.apache.spark.sql.connect.planner.SparkConnectPlanner +import org.apache.spark.sql.connect.service.SessionHolder + +object MLUtils { + + def setInstanceParams(instance: Params, paramsProto: proto.Params): Unit = { + import scala.collection.JavaConverters._ + paramsProto.getParamsMap.asScala.foreach { case (paramName, paramValueProto) => + val paramDef = instance.getParam(paramName) + val paramValue = parseParamValue(paramDef.paramValueClassTag.runtimeClass, paramValueProto) + instance.set(paramDef, paramValue) + } + paramsProto.getDefaultParamsMap.asScala.foreach { case (paramName, paramValueProto) => + val paramDef = instance.getParam(paramName) + val paramValue = parseParamValue(paramDef.paramValueClassTag.runtimeClass, paramValueProto) + instance._setDefault(paramDef -> paramValue) + } + } + + def parseParamValue(paramType: Class[_], paramValueProto: proto.Expression.Literal): Any = { Review Comment: No. The purpose of `paramType` is: in pyspark, we cannot distinguish int/long, double/float, so when send it to server, int becomes long, and float becomes double, we need to get the accurate param type otherwise JVM will raise error in runtime. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
