LuciferYang commented on PR #40332: URL: https://github.com/apache/spark/pull/40332#issuecomment-1461183365
> probably not related to this PR: > > https://github.com/apache/spark/blob/39a55121888d2543a6056be65e0c74126a9d3bdf/connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/DataFrameReader.scala#L63-L76 > > ``` > def schema(schemaString: String): DataFrameReader = { > schema(StructType.fromDDL(schemaString)) > } > ``` > > when the user provide a DDL string, it invoke the parser. Here I think we should keep both StructType and DDL string, and pass them to the server side. message `Read` seems also need to consider this？I think we can further discuss this problem in a separate jira? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
