cloud-fan commented on code in PR #39990:
URL: https://github.com/apache/spark/pull/39990#discussion_r1130957560
##########
connector/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/v2/V2JDBCTest.scala:
##########
@@ -410,6 +410,16 @@ private[v2] trait V2JDBCTest extends SharedSparkSession
with DockerIntegrationFu
assert(sorts.isEmpty)
}
+ private def offsetPushed(df: DataFrame, offset: Int): Boolean = {
Review Comment:
nvm, this two functions return a boolean. We can rename them if we update
them to do the check directly instead of returning boolean, e.g. passing `-1`
means pushdown should not happen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
