ulysses-you commented on code in PR #39624:
URL: https://github.com/apache/spark/pull/39624#discussion_r1132194413
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AdaptiveSparkPlanExec.scala:
##########
@@ -345,7 +359,7 @@ case class AdaptiveSparkPlanExec(
// Subqueries that don't belong to any query stage of the main query will
execute after the
// last UI update in `getFinalPhysicalPlan`, so we need to update UI here
again to make sure
// the newly generated nodes of those subqueries are updated.
- if (!isSubquery && currentPhysicalPlan.exists(_.subqueries.nonEmpty)) {
+ if (shouldUpdatePlan && currentPhysicalPlan.exists(_.subqueries.nonEmpty))
{
Review Comment:
`shouldUpdatePlan` is not required since we already checked it inside
`onUpdatePlan`. The reason leave it here is to fast skip
`currentPhysicalPlan.exists(_.subqueries.nonEmpty)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
