srowen commented on code in PR #40347: URL: https://github.com/apache/spark/pull/40347#discussion_r1132662726
########## build/sbt: ########## @@ -17,7 +17,7 @@ # limitations under the License. # -SELF=$(cd $(dirname $0) && pwd) +SELF=$(cd "$(dirname "$0")" && pwd) Review Comment: Are these changes necessary/related? ########## build/sbt: ########## @@ -62,7 +63,7 @@ Usage: $script_name [options] -sbt-rc use an RC version of sbt -sbt-snapshot use a snapshot version of sbt - # java version (default: java from PATH, currently $(java -version 2>&1 | grep version)) + # JAVA_HOME (this will override default JAVA_HOME) Review Comment: I'm not sure I understand your new comment. What is this telling users? it overrides JAVA_HOME, but it says JAVA_HOME overrides JAVA_HOME .. ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org