zhengruifeng opened a new pull request, #40375:
URL: https://github.com/apache/spark/pull/40375

   ### What changes were proposed in this pull request?
   Factor literal value conversion out to `connect-common`.
   Also rename the files to make it more clearer:
   `LiteralValueProtoConverter` in common module  `value: Any` -> 
`proto.Expression.Literal` 
   `LiteralExpressionProtoConverter` in server module  
`proto.Expression.Literal` -> `catalyst.expressions.Literal`
   
   ### Why are the changes needed?
   when we want to build protos of literal array in the server side for ml, we 
found we have to implementations:
   
   `LiteralExpressionProtoConverter. toConnectProtoValue`  in server module, 
but it doesn't support array;
   `LiteralProtoConverter. toLiteralProto` in client module, it support more 
types;
   
   We'd better factor it out to common module, so that both client and server 
can leverage it.
   
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   existing UT


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to