zhengruifeng commented on PR #40097:
URL: https://github.com/apache/spark/pull/40097#issuecomment-1467297939
> For the 2 exceptions:
>
> > 2, org.apache.spark.ml.linalg.* except VectorUDTSuite due to cyclical
dependency; (it copies the VectorUDTSuite except test("JavaTypeInference with
VectorUDT"))
> > 3, org.apache.spark.ml.param.* except ParamsSuite due to cyclical
dependency; (it copies the ParamsSuite except test("Filtering ParamMap"))
>
> You can move "JavaTypeInference with VectorUDT" out of VectorUDTSuite, and
move "Filtering ParamMap" out of ParamsSuite, and then can move remaining test
code without duplication.
good point, done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
