HyukjinKwon commented on code in PR #40377:
URL: https://github.com/apache/spark/pull/40377#discussion_r1135382569
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/DataFrameReader.scala:
##########
@@ -531,10 +531,7 @@ class DataFrameReader private[sql] (sparkSession:
SparkSession) extends Logging
*/
@scala.annotation.varargs
def textFile(paths: String*): Dataset[String] = {
- // scalastyle:off throwerror
- // TODO: this method can be supported and should be included in the client
API.
- throw new NotImplementedError()
- // scalastyle:on throwerror
Review Comment:
Meaning that adding:
```diff
def textFile(paths: String*): Dataset[String] = {
+ assertNoSpecifiedSchema("textFile")
text(paths :
_*).select("value").as[String](sparkSession.implicits.newStringEncoder)
}
```
check.
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/DataFrameReader.scala:
##########
@@ -531,10 +531,7 @@ class DataFrameReader private[sql] (sparkSession:
SparkSession) extends Logging
*/
@scala.annotation.varargs
def textFile(paths: String*): Dataset[String] = {
- // scalastyle:off throwerror
- // TODO: this method can be supported and should be included in the client
API.
- throw new NotImplementedError()
- // scalastyle:on throwerror
Review Comment:
Meaning that adding:
```diff
def textFile(paths: String*): Dataset[String] = {
+ assertNoSpecifiedSchema("textFile")
text(paths :
_*).select("value").as[String](sparkSession.implicits.newStringEncoder)
}
```
check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
