WeichenXu123 commented on code in PR #40297: URL: https://github.com/apache/spark/pull/40297#discussion_r1135600960
########## connector/connect/common/src/main/protobuf/spark/connect/ml.proto: ########## @@ -0,0 +1,176 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +syntax = 'proto3'; + +package spark.connect; + +import "spark/connect/expressions.proto"; +import "spark/connect/relations.proto"; +import "spark/connect/ml_common.proto"; + +option java_multiple_files = true; +option java_package = "org.apache.spark.connect.proto"; + + +message MlEvaluator { + string name = 1; + MlParams params = 2; + string uid = 3; +} + + +message MlCommand { + oneof ml_command_type { + Fit fit = 1; + FetchModelAttr fetch_model_attr = 2; + FetchModelSummaryAttr fetch_model_summary_attr = 3; + LoadModel load_model = 4; + SaveModel save_model = 5; + Evaluate evaluate = 6; + SaveStage save_stage = 7; + LoadStage load_stage = 8; + SaveEvaluator save_evaluator = 9; + LoadEvaluator load_evaluator = 10; + CopyModel copy_model = 11; + DeleteModel delete_model = 12; + } + + message Fit { + MlStage estimator = 1; + Relation dataset = 2; + } + + message Evaluate { + MlEvaluator evaluator = 1; + } + + message LoadModel { Review Comment: Btw, supporting 3rd-party estimators is risky, because in shared cluster we will [binpack the spark workers across different customers](https://docs.google.com/document/d/1sJVjan44XagM48PEqdkg6KWctpPcz54Urf0i_-dGesA/edit?disco=AAAArl9hpF8) But 3rd-party estimators implementation might invoke RDD transformation (e.g. RDD.map) that we cannot isolate them by container. So it is risky if we allow user uses 3rd-party estimators on shared cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
