dongjoon-hyun commented on code in PR #40396:
URL: https://github.com/apache/spark/pull/40396#discussion_r1136636446
##########
sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala:
##########
@@ -583,12 +583,16 @@ abstract class JdbcDialect extends Serializable with
Logging {
* {@link OracleDialect.OracleSQLQueryBuilder} and
* {@link MsSqlServerDialect.MsSqlServerSQLQueryBuilder}.
*/
- def supportsLimit: Boolean = true
+ def supportsLimit: Boolean = false
/**
* Returns ture if dialect supports OFFSET clause.
+ *
+ * Note: Some build-in dialect supports OFFSET clause with some trick,
please see:
+ * {@link OracleDialect.OracleSQLQueryBuilder} and
+ * {@link MySQLDialect.MySQLSQLQueryBuilder}.
*/
- def supportsOffset: Boolean = true
+ def supportsOffset: Boolean = false
Review Comment:
ditto. We should not change `JdbcDialects`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
