zhengruifeng commented on code in PR #40432: URL: https://github.com/apache/spark/pull/40432#discussion_r1138017400
########## dev/sparktestsupport/modules.py: ########## @@ -781,6 +740,57 @@ def __hash__(self): ], ) + +pyspark_connect = Module( + name="pyspark-connect", + dependencies=[pyspark_sql, pyspark_ml, connect], + source_file_regexes=[ + "python/pyspark/sql/connect", + "python/pyspark/ml/connect", Review Comment: @HyukjinKwon I made an additional change, make `pyspark-connect` depends on `pyspark_ml` and then move ml tests here. since I think it maybe not a good idea to make `pyspark_ml` depends on `connect` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org