WeichenXu123 commented on code in PR #40297:
URL: https://github.com/apache/spark/pull/40297#discussion_r1138372032
##########
mllib/common/src/main/scala/org/apache/spark/ml/param/params.scala:
##########
@@ -793,6 +800,10 @@ trait Params extends Identifiable with Serializable {
this
}
+ private[spark] def _setDefault(paramPairs: ParamPair[_]*): this.type = {
+ setDefault(paramPairs: _*)
+ }
Review Comment:
> I think we can simply change setDefault to protected[spark] ?
This should be a breaking change.
Some 3rd-party estimator might override this method, if they are not under
"org.apach" package, then compiling will fail.
##########
mllib/common/src/main/scala/org/apache/spark/ml/param/params.scala:
##########
@@ -793,6 +800,10 @@ trait Params extends Identifiable with Serializable {
this
}
+ private[spark] def _setDefault(paramPairs: ParamPair[_]*): this.type = {
+ setDefault(paramPairs: _*)
+ }
Review Comment:
> I think we can simply change setDefault to protected[spark] ?
This should be a breaking change.
Some 3rd-party estimator might override this method, if they are not under
"org.apache" package, then compiling will fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
