yabola commented on code in PR #39950:
URL: https://github.com/apache/spark/pull/39950#discussion_r1138487479
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala:
##########
@@ -182,6 +186,9 @@ class ParquetFileFormat
val parquetOptions = new ParquetOptions(options,
sparkSession.sessionState.conf)
val datetimeRebaseModeInRead = parquetOptions.datetimeRebaseModeInRead
val int96RebaseModeInRead = parquetOptions.int96RebaseModeInRead
+ // whether read the complete row groups in advance (filter the row groups
later if need)
+ // this can avoid reading the footer twice (currently only optimize for
vectorized read)
+ val readRowGroupsEarly = enableVectorizedReader
Review Comment:
now only optimize for vectorized read.
non-vectorized reader use api
`org.apache.hadoop.mapreduce.RecordReader#initialize` , I can't pass the footer
parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
