ritikam2 commented on code in PR #40116:
URL: https://github.com/apache/spark/pull/40116#discussion_r1141633293
##########
sql/core/src/main/scala/org/apache/spark/sql/RelationalGroupedDataset.scala:
##########
@@ -89,9 +89,22 @@ class RelationalGroupedDataset protected[sql](
case expr: NamedExpression => expr
case a: AggregateExpression if
a.aggregateFunction.isInstanceOf[TypedAggregateExpression] =>
UnresolvedAlias(a, Some(Column.generateAlias))
- case expr: Expression => Alias(expr, toPrettySQL(expr))()
+ case ag: UnresolvedFunction if (containsStar(Seq(ag))) || ag.isDistinct =>
+ UnresolvedAlias(expr, None)
+ case expr: Expression =>
+ if (containsStar(Seq(expr))) {
+ UnresolvedAlias(expr, None)
+ } else {
+ Alias(expr, toPrettySQL(expr))()
Review Comment:
> If we want a surgical fix, shall we fix how `toPrettySQL` handles star?
Sure we can fix toPrettySQL. But the best we can do is to get count(distinct
*) which is not the same as what spark.sql produces.
If we want to duplicate spark.sql behavior the best option would be to
create unresolvedAlias for expr containing "*" as pushed in the latest build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
