LuciferYang commented on code in PR #40504:
URL: https://github.com/apache/spark/pull/40504#discussion_r1143279989
##########
docs/running-on-yarn.md:
##########
@@ -137,7 +137,7 @@ Note that for the first option, both executors and the
application master will s
log4j configuration, which may cause issues when they run on the same node
(e.g. trying to write
to the same log file).
-If you need a reference to the proper location to put log files in the YARN so
that YARN can properly display and aggregate them, use
`spark.yarn.app.container.log.dir` in your `log4j.properties`. For example,
`log4j.appender.file_appender.File=${spark.yarn.app.container.log.dir}/spark.log`.
For streaming applications, configuring `RollingFileAppender` and setting file
location to YARN's log directory will avoid disk overflow caused by large log
files, and logs can be accessed using YARN's log utility.
+If you need a reference to the proper location to put log files in the YARN so
that YARN can properly display and aggregate them, use
`spark.yarn.app.container.log.dir` in your `log4j.properties`. For example,
`appender.spark.fileName=${sys:spark.yarn.app.container.log.dir}/spark.log`.
For streaming applications, configuring `RollingFileAppender` and setting file
location to YARN's log directory will avoid disk overflow caused by large log
files, and logs can be accessed using YARN's log utility.
Review Comment:
`sys:` is ok ~ but I don't think we need change `file_appender` to `spark`
and I think `log4j.properties` should change to `log4j2.properties`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
