grundprinzip commented on code in PR #39294:
URL: https://github.com/apache/spark/pull/39294#discussion_r1144010201
##########
.github/workflows/build_and_test.yml:
##########
@@ -493,6 +494,80 @@ jobs:
name: test-results-sparkr--8-${{ inputs.hadoop }}-hive2.3
path: "**/target/test-reports/*.xml"
+ proto-breaking-changes-check-master:
+ needs: [precondition]
+ if: always() &&
fromJson(needs.precondition.outputs.required).proto-breaking-changes-check ==
'true'
+ name: Spark Connect proto backwards compatibility check (master)
+ continue-on-error: true
+ runs-on: ubuntu-22.04
+ env:
+ LC_ALL: C.UTF-8
+ LANG: C.UTF-8
+ PYSPARK_DRIVER_PYTHON: python3.9
+ PYSPARK_PYTHON: python3.9
+ steps:
+ - name: Checkout Spark repository
+ uses: actions/checkout@v3
+ with:
+ fetch-depth: 0
+ repository: apache/spark
+ ref: ${{ inputs.branch }}
+ - name: Add GITHUB_WORKSPACE to git trust safe.directory
+ run: |
+ git config --global --add safe.directory ${GITHUB_WORKSPACE}
+ - name: Sync the current branch with the latest in Apache Spark
+ if: github.repository != 'apache/spark'
+ run: |
+ git fetch https://github.com/$GITHUB_REPOSITORY.git
${GITHUB_REF#refs/heads/}
+ git -c user.name='Apache Spark Test Account' -c
user.email='sparktest...@gmail.com' merge --no-commit --progress --squash
FETCH_HEAD
+ git -c user.name='Apache Spark Test Account' -c
user.email='sparktest...@gmail.com' commit -m "Merged commit" --allow-empty
+ # Install the `buf` CLI
+ - uses: bufbuild/buf-setup-action@v1
+ with:
+ github_token: ${{ secrets.GITHUB_TOKEN }}
+ # Run buf breaking.
+ - uses: bufbuild/buf-breaking-action@v1
+ with:
+ input: connector/connect/common/src/main
+ against:
'https://github.com/apache/spark.git#branch=master,subdir=connector/connect/common/src/main'
+
+ proto-breaking-changes-check-release:
+ needs: [precondition]
+ if: always() &&
fromJson(needs.precondition.outputs.required).proto-breaking-changes-check ==
'true'
+ name: Spark Connect proto backwards compatibility check (master)
+ runs-on: ubuntu-22.04
+ env:
+ LC_ALL: C.UTF-8
+ LANG: C.UTF-8
+ PYSPARK_DRIVER_PYTHON: python3.9
+ PYSPARK_PYTHON: python3.9
+ steps:
+ - name: Checkout Spark repository
+ uses: actions/checkout@v3
+ with:
+ fetch-depth: 0
+ repository: apache/spark
+ ref: ${{ inputs.branch }}
+ - name: Add GITHUB_WORKSPACE to git trust safe.directory
+ run: |
+ git config --global --add safe.directory ${GITHUB_WORKSPACE}
+ - name: Sync the current branch with the latest in Apache Spark
+ if: github.repository != 'apache/spark'
+ run: |
+ git fetch https://github.com/$GITHUB_REPOSITORY.git
${GITHUB_REF#refs/heads/}
+ git -c user.name='Apache Spark Test Account' -c
user.email='sparktest...@gmail.com' merge --no-commit --progress --squash
FETCH_HEAD
+ git -c user.name='Apache Spark Test Account' -c
user.email='sparktest...@gmail.com' commit -m "Merged commit" --allow-empty
+ # Install the `buf` CLI
+ - uses: bufbuild/buf-setup-action@v1
+ with:
+ github_token: ${{ secrets.GITHUB_TOKEN }}
+ # Run buf breaking.
+ - uses: bufbuild/buf-breaking-action@v1
+ with:
+ input: connector/connect/common/src/main
+ against:
'https://github.com/apache/spark.git#branch=branch-3.4,subdir=connector/connect/common/src/main'
Review Comment:
runs against the 3.4 release branch, this has to be updated on every release
to the previous branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
