LuciferYang opened a new pull request, #40518:
URL: https://github.com/apache/spark/pull/40518

   ### What changes were proposed in this pull request?
   https://github.com/apache/spark/pull/40510 introduce `message StorageLevel` 
to `base.proto`, but if we try to import `base.proto` in `catalog.proto` to 
reuse `StorageLevel` in `message CacheTable` and run `build/sbt 
"connect-common/compile" to compile, there will be following message in compile 
log:
   
   ```
   spark/connect/base.proto:23:1: File recursively imports itself: 
spark/connect/base.proto -> spark/connect/commands.proto -> 
spark/connect/relations.proto -> spark/connect/catalog.proto -> 
spark/connect/base.proto
   spark/connect/catalog.proto:22:1: Import "spark/connect/base.proto" was not 
found or had errors.
   spark/connect/catalog.proto:144:12: "spark.connect.DataType" seems to be 
defined in "spark/connect/types.proto", which is not imported by 
"spark/connect/catalog.proto".  To use it here, please add the necessary import.
   spark/connect/catalog.proto:161:12: "spark.connect.DataType" seems to be 
defined in "spark/connect/types.proto", which is not imported by 
"spark/connect/catalog.proto".  To use it here, please add the necessary import.
   spark/connect/relations.proto:25:1: Import "spark/connect/catalog.proto" was 
not found or had errors.
   spark/connect/relations.proto:84:5: "Catalog" is not defined.
   spark/connect/commands.proto:22:1: Import "spark/connect/relations.proto" 
was not found or had errors.
   spark/connect/commands.proto:63:3: "Relation" is not defined.
   spark/connect/commands.proto:81:3: "Relation" is not defined.
   spark/connect/commands.proto:142:3: "Relation" is not defined.
   spark/connect/base.proto:23:1: Import "spark/connect/commands.proto" was not 
found or had errors.
   spark/connect/base.proto:25:1: Import "spark/connect/relations.proto" was 
not found or had errors.
   ....
   ```
   
   So this pr move `message StorageLevel` to a separate file to avoid this 
potential file recursively imports.
   
   
   ### Why are the changes needed?
   To avoid potential file recursively imports.
   
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   Pass GitHub Actions


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to