beliefer commented on code in PR #40528:
URL: https://github.com/apache/spark/pull/40528#discussion_r1145613769
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/Column.scala:
##########
@@ -1213,11 +1213,8 @@ class Column private[sql] (private[sql] val expr:
proto.Expression) extends Logg
*/
def explain(extended: Boolean): Unit = {
// scalastyle:off println
- if (extended) {
- println(expr)
- } else {
- println(toString)
- }
+ val builder = new ProtoExpressionSQLBuilder(expr, extended)
+ println(builder.build())
Review Comment:
@hvanhovell It looks like `extended` won't be useful anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
