yaooqinn commented on code in PR #40533:
URL: https://github.com/apache/spark/pull/40533#discussion_r1145877352
##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesConf.scala:
##########
@@ -255,13 +255,17 @@ private[spark] object KubernetesConf {
s"spark-${UUID.randomUUID().toString.replaceAll("-", "")}"
def getResourceNamePrefix(appName: String): String = {
- val id = KubernetesUtils.uniqueID()
- s"$appName-$id"
- .trim
- .toLowerCase(Locale.ROOT)
- .replaceAll("[^a-z0-9\\-]", "-")
Review Comment:
how about replacing these characters with 'x', which makes us easily refer
to unknown ones?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
