peter-toth commented on code in PR #40266:
URL: https://github.com/apache/spark/pull/40266#discussion_r1145917715
##########
sql/core/src/test/resources/tpcds-plan-stability/approved-plans-v1_4/q10.sf100/explain.txt:
##########
@@ -4,67 +4,67 @@ TakeOrderedAndProject (51)
+- Exchange (49)
+- * HashAggregate (48)
+- * Project (47)
- +- * SortMergeJoin Inner (46)
- :- * Sort (40)
- : +- Exchange (39)
- : +- * Project (38)
- : +- * BroadcastHashJoin Inner BuildRight (37)
- : :- * Project (31)
- : : +- * Filter (30)
- : : +- * SortMergeJoin ExistenceJoin(exists#1)
(29)
- : : :- * SortMergeJoin ExistenceJoin(exists#2)
(21)
- : : : :- * SortMergeJoin LeftSemi (13)
- : : : : :- * Sort (5)
- : : : : : +- Exchange (4)
- : : : : : +- * Filter (3)
- : : : : : +- * ColumnarToRow (2)
- : : : : : +- Scan parquet
spark_catalog.default.customer (1)
- : : : : +- * Sort (12)
- : : : : +- Exchange (11)
- : : : : +- * Project (10)
- : : : : +- * BroadcastHashJoin
Inner BuildRight (9)
- : : : : :- * ColumnarToRow (7)
- : : : : : +- Scan parquet
spark_catalog.default.store_sales (6)
- : : : : +- ReusedExchange (8)
- : : : +- * Sort (20)
- : : : +- Exchange (19)
- : : : +- * Project (18)
- : : : +- * BroadcastHashJoin Inner
BuildRight (17)
- : : : :- * ColumnarToRow (15)
- : : : : +- Scan parquet
spark_catalog.default.web_sales (14)
- : : : +- ReusedExchange (16)
- : : +- * Sort (28)
- : : +- Exchange (27)
- : : +- * Project (26)
- : : +- * BroadcastHashJoin Inner
BuildRight (25)
- : : :- * ColumnarToRow (23)
- : : : +- Scan parquet
spark_catalog.default.catalog_sales (22)
- : : +- ReusedExchange (24)
- : +- BroadcastExchange (36)
- : +- * Project (35)
- : +- * Filter (34)
- : +- * ColumnarToRow (33)
- : +- Scan parquet
spark_catalog.default.customer_address (32)
- +- * Sort (45)
- +- Exchange (44)
- +- * Filter (43)
- +- * ColumnarToRow (42)
- +- Scan parquet
spark_catalog.default.customer_demographics (41)
+ +- * Filter (46)
+ +- * SortMergeJoin ExistenceJoin(exists#1) (45)
Review Comment:
`Filter (46)`'s condition is `exists#2 OR exists#1`, that can't be pushed
down. But that's ok as it is basically the same as the old `Filter (30)` was.
In the new plan the order of joins are a bit different, but I'm not sure the
new plan would be worse. Actually we have 3 SMJ + 5 BHJ now whereas we had 4 +
4...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
