HyukjinKwon commented on code in PR #40536:
URL: https://github.com/apache/spark/pull/40536#discussion_r1147056718
##########
python/pyspark/sql/connect/client.py:
##########
@@ -513,8 +513,11 @@ class SparkConnectClient(object):
"""
@classmethod
- def retry_exception(cls, e: grpc.RpcError) -> bool:
- return e.code() == grpc.StatusCode.UNAVAILABLE
+ def retry_exception(cls, e: Exception) -> bool:
+ if isinstance(e, grpc.RpcError):
+ return e.code() == grpc.StatusCode.UNAVAILABLE
+ else:
+ return False
Review Comment:
Hm, why don't we just throw an exception here?
I am sure there are more places than just `SparkSession` that does the
connection to the server side, e.g., `DataFrame.collect()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
