yaooqinn commented on code in PR #40543:
URL: https://github.com/apache/spark/pull/40543#discussion_r1148752533


##########
connector/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/PostgresIntegrationSuite.scala:
##########
@@ -128,7 +128,7 @@ class PostgresIntegrationSuite extends 
DockerJDBCIntegrationSuite {
       "('abcd', 'efgh', 'ijkl', 'mnop', 'q')").executeUpdate()
 
     conn.prepareStatement("CREATE TABLE char_array_types (" +
-      "c0 char(4)[], c1 character(4)[], c2 character varying(4)[], c3 
varchar(4)[], c4 bpchar[])"
+      "c0 char(4)[], c1 character(4)[], c2 character varying(4)[], c3 
varchar(4)[], c4 bpchar(1)[])"

Review Comment:
   According to the pg's doc, char w/o length specifier is char(1). While based 
on my offline testing with pgjdbc, the precision here is int.max, which causes 
the tests fail with OOM. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to