Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/6277#discussion_r30767047
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/NaiveBayes.scala ---
@@ -272,12 +278,11 @@ class NaiveBayes private (
/**
* Set the model type using a string (case-sensitive).
- * Supported options: "Multinomial" and "Bernoulli".
- * (default: Multinomial)
+ * Supported options: "multinomial" (default) and "bernoulli".
*/
- def setModelType(modelType:String): NaiveBayes = {
+ def setModelType(modelType: String): NaiveBayes = {
--- End diff --
I tried that option in the first version. Making it case-insensitive is
easy but it may cause unexpected errors in the user code.
~~~scala
nb.setModelType("Bernoulli")
if (nb.getModelType() == "Bernoulli") { // It becomes lowercase here.
...
}
~~~
I can keep the input untouched but call `toLowerCase every time we need it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
