pan3793 commented on code in PR #40578:
URL: https://github.com/apache/spark/pull/40578#discussion_r1150721270
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashJoin.scala:
##########
@@ -131,7 +131,7 @@ trait HashJoin extends JoinCodegenSupport {
@transient protected lazy val streamedBoundKeys =
bindReferences(HashJoin.rewriteKeyExpr(streamedKeys), streamedOutput)
- protected def buildSideKeyGenerator(): Projection =
+ protected def buildSideKeyGenerator(): UnsafeProjection =
Review Comment:
keep consistent w/ `def streamSideKeyGenerator()`, actually this method can
be removed since it's unused
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
